feat: add async api #461
Merged
feat: add async api #461
+177
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanhelsing
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
This looks really useful. And like you say, an easy win.
Sorry for the slow response. We are most likely removing the typestate pattern from the matchbox socket so might need an update if #468 gets in first.
|
#468 is in. If you fix the conflicts, we'll get this in in time for the 0.11 release |
|
wait a second. I think I introduced a bug... |
|
should be good now 👍 |
|
Thanks, sorry if it sounded like I was demanding something. I really appreciate your help and totally respect people being busy or having lower capacity at times (otherwise I'd be a total hypocrite :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an async api:
SinkandStreamforWebRtcChannelRawPeerChannelwithAsyncReadandAsyncWritesupporttake_rawandtake_raw_by_idonWebRtcSocketCloses: #453